Fix o3 issues on product-metrics script

docs/calculate-issues.md

@@ -1,4 +1,4 @@
-1. **Missing Updates for Reorder Point and Safety Stock**
+1. **Missing Updates for Reorder Point and Safety Stock** [RESOLVED - product-metrics.js]
 - **Problem:** In the **product_metrics** table (used by the inventory health view), the fields **reorder_point** and **safety_stock** are never updated in the product metrics calculations. Although a helper function (`calculateReorderQuantities`) exists and computes these values, the update query in the `calculateProductMetrics` function does not assign any values to these columns.
 - **Effect:** The inventory health view relies on these fields (using COALESCE to default them to 0), which means that stock might never be classified as "Reorder" or "Healthy" based on the proper reorder point or safety stock calculations.
 - **Example:** Even if a product's base metrics would require a reorder (for example, if its days of inventory are low), the view always shows a value of 0 for reorder_point and safety_stock.
@@ -10,7 +10,7 @@
 - **Example:** An external caller expecting to run `calculateMetrics` would instead receive the `calculateProductMetrics` function.
 - **Fix:** Make sure each script resides in its own module file. Verify that the module boundaries and exports are not accidentally merged or overwritten when deployed.
 
-3. **Potential Formula Issue in EOQ Calculation (Reorder Qty)**
+3. **Potential Formula Issue in EOQ Calculation (Reorder Qty)** [RESOLVED - product-metrics.js]
 - **Problem:** The helper function `calculateReorderQuantities` uses an EOQ formula with a holding cost expressed as a percentage (0.25) rather than a per‐unit cost.
 - **Effect:** If the intent was to use the traditional EOQ formula (which expects a holding cost per unit rather than a percentage), this could lead to an incorrect reorder quantity.
 - **Example:** For a given annual demand and fixed order cost, the computed reorder quantity might be higher or lower than expected.